ROS SPICE Data Set Release 0004 Review notes
BVS/NAIF, June 13, 2019
===========================================================================

on RO-RL-E-M-A-C-SPICE-6-V1.0_rel0004_20190607.tar provided on June 7, 2019

md5sum:

ff7fda1dedc8687c7befb298e015e7f7


===========================================================================
Notes on kernel data and comments:
===========================================================================
\color{red}

\begin{solved}
DATA/FK/ROS_DSK_SURFACES_V02.TF

-- Just a note: PHOBOS_K137_DLR_V01 could have been corrected as well 
   (PHOBOS_K137_DLR_V01 -> PHOBOS_K275_DLR_V02) but its OK to leave 
   ROS_DSK_SURFACES_V02.TF as is for the archive because only V02 DSK
   is included.
\end{solved}

\BG{
  Noted this down for the next SKD release.
}

\begin{solved}
DATA/SPK/ROS_COG_V4.BSP

-- times are not correct in this sentence in comments:

      The original data covered the time from 2004 MAR 02 09:25:17.397
      to 2014 AUG 01 00:01:07.183 UTC.

   It should be

      The original data covered the time from 2014 AUG 01 00:01:07.183
      to 2016 OCT 01 00:01:08.182 UTC.
\end{solved}

\BG{
  Corrected the times in the comment accordingly. Updated also the version
  history. The re-made kernel is put in the staging area by the Makefile.
  Cleaned the SPK directory and rerun arcgen.
}

\begin{solved}
===========================================================================
Long lines in meta-files:
===========================================================================


DATA/FK/ROS_DSK_SURFACES_V02.LBL

-- long lines

   Line 64 is too long (86 chars).
   Line 65 is too long (81 chars).
\end{solved}

\BG{
  Reformated the description in fk/aareadme.txt in the staging area, cleaned
  the FK directory, and re-run arcgen.
}

\begin{solved}
DATA/IK/ROS_ALICE_V17.LBL

-- long lines

   Line 70 is too long (83 chars).



DATA/IK/ROS_MIRO_V11.LBL

-- long lines

  Line 68 is too long (81 chars).



DATA/IK/ROS_ROSINA_V12.LBL

-- long lines

   Line 71 is too long (85 chars).
   Line 72 is too long (82 chars).



DATA/IK/ROS_SREM_V01.LBL

-- long lines

  Line 68 is too long (81 chars).



DATA/IK/ROS_VIRTIS_V14.LBL

-- long lines

   Line 73 is too long (85 chars).
\end{solved}

\BG{
  Reformated all the respective descriptions in ik/aareadme.txt in the
  staging area, cleaned the IK directory, and re-run arcgen.
}

\begin{solved}
===========================================================================
DOCUMENT/*INFO.TXT files
===========================================================================


DOCUMENT/FKINFO.TXT

-- has non-ASCII characters -- 4 TABs on line

				team: Phobos, Deimos and Tempel 1.


DOCUMENT/IKINFO.TXT

-- mentions ROS_STR_V11.TI that is not present in the archive.



DOCUMENT/SPKINFO.TXT

-- mentions ROS_COG_V3.BSP that is not present in the archive
\end{solved}

\BG{
  Corrected all this (in my project area; the files are inserted in the
  arcgen output directory by the Makefile, with the last one having the
  lines shortened on the fly).
}

\begin{solved}
===========================================================================
EXTRAS/MK
===========================================================================


EXTRAS/MK/MKINFO.TXT

-- has non-ASCII characters -- TABs on lines

	    (C2002_T7_LINEAR_HOR_V01.BSP, C2004_Q2_MACHHOLZ_HOR_V01.BSP,
	    C2010_A2_LINEAR_HOR_V01.BSP, VESTA_HOR_V01.BSP,
	    MAR097_030101_170101_V0001.BSP)

	    (ROS_COG_V?.BSP)

	    applicability; instead the comet orientation should be computed
	    using CKs containing data for the 67P/C-G_CK reference frame.
\end{solved}

\BG{
  Replaced the TABs by blanks (in my project area; the file is inserted in
  the arcgen output directory by the Makefile).
}

\begin{solved}
EXTRAS/MK/ROS_V06.TM

-- need to change date/author in the comments, from

      November 7, 2017 by Marc Costa Sitja

   to

      June 7, 2019 by Bjoern Grieger


-- these SPKs

                          '$KERNELS/SPK/RORB_DV_145_01___T19_00216.BSP'
                          '$KERNELS/SPK/RORB_DV_223_01___T19_00302.BSP'

   do not need to be included because their data is completely masked by

                          '$KERNELS/SPK/RORB_DV_257_03___T19_00345.BSP'

   In fact, maybe  RORB_DV_223_01___T19_00302.BSP should not even be
   included in the archive because RORB_DV_257_03___T19_00345.BSP fully
   supersedes it. If you decide to drop it and its label, please update
   both MKs and SPKINFO.TXT, as well as INDEX and CHECKSUM (probably
   done automatically).

   We cannot drop RORB_DV_145_01___T19_00216.BSP, which was added in
   the previous release.
\end{solved}

\BG{
  At this occasion, I abandon editing the metakernel in place in the arcgen
  output and instead maintain it in my project area and have it inserted
  in the arcgen output by the Makefile. I will create the version with DSKs
  automatically. Corrected date/author, removed the two superseded SPKs (from
  the MK). I am reluctant to remove any of them from the archive, as with
  the same argument also RORB_DV_257_02___T19_00344.BSP should be removed.
  A user may be confused by seeing different sets for T19 and non-T19 kernels.
  Also, the DV_257_03 version was created by merging three kernels. If we
  later find out that the merging behaved not well at the boundaries, we have
  lost some information. The same applies to the CORB kernels.
}     

\begin{solved}
EXTRAS/MK/ROS_WITH_DSK_V06.TM

-- is not loadable. It includes ROS_COG_V3.BSP that is not in the archive. 
   It should be ROS_COG_V3.BSP.


-- change MK name embedded in the comments

      The original name of this file was ROS_V06.TM.

   to match actual name:

      The original name of this file was ROS_WITH_DSK_V06.TM.


-- need to change date/author in the comments, from

      November 7, 2017 by Marc Costa Sitja

   to

      June 7, 2019 by Bjoern Grieger


-- these SPKs

                          '$KERNELS/SPK/RORB_DV_145_01___T19_00216.BSP'
                          '$KERNELS/SPK/RORB_DV_223_01___T19_00302.BSP'

   do not need to be included because their data is completely masked by

                          '$KERNELS/SPK/RORB_DV_257_03___T19_00345.BSP'
\end{solved}

\BG{
  Wrote a script to create the version WITH_DSK from ROS_V06.TM by
  replacing the original file name and adding the DSKs.
}

\color{black}
===========================================================================
Other 
===========================================================================


-- checksum check is OK



-- all kernels, labels, catalogs, text files not mentioned in the notes
   above are OK.



===========================================================================
End.
===========================================================================
